Fix reported dashboard ip when using 0.0.0.0 #15506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fyrestone
added
bug
kfstorm
reviewed
Apr 26, 2021
| assert webui_ip in [ | ||
| "127.0.0.1", ray_start_with_dashboard["node_ip_address"] | ||
| ] | ||
|
|
There was a problem hiding this comment.
We should also verify that the ip:port stored in redis is correct.
There was a problem hiding this comment.
The webui_url returned from ray.init() is fetched from redis. Please refer to: https://github.com/ray-project/ray/blob/master/python/ray/_private/services.py#L1221
kfstorm
approved these changes
Apr 26, 2021
edoakes
approved these changes
Apr 26, 2021
fyrestone
changed the title
|
test_reference_counting in Windows CI failed. It should be unrelated. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
ray.init(dashboard_host='0.0.0.0'returns ahttp://0.0.0.0:8265as the webui url.Related issue number
N/A
Checks
scripts/format.shto lint the changes in this PR.