[rllib] check if self.env is not None
explicitly
#15634
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The rollout worker
stop()
method usesif self.env
to evaluate whetherself.env
isNone
. This can cause errors if the user'senv
class implements__len__()
. I discovered this because I use the same class as a Gym env and as a PyTorch dataset for pretraining, which requires implementing__len__()
.Related issue number
Checks
Since I changed only one line, I did not run the unit tests locally, sorry :(
scripts/format.sh
to lint the changes in this PR.