Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serve] Skip test_router on Windows #15651

Merged
merged 1 commit into from May 5, 2021
Merged

[Serve] Skip test_router on Windows #15651

merged 1 commit into from May 5, 2021

Conversation

simon-mo
Copy link
Contributor

@simon-mo simon-mo commented May 5, 2021

The test is platform agnostic anyway and no need to test it on windows.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simon-mo
[Serve] Skip test_router on Windows
88da99b 
The test is platform agnostic anyway and no need to test it on windows.
ijrsvt
ijrsvt approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@ijrsvt ijrsvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simon-mo simon-mo merged commit 7bbf482 into ray-project:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijrsvt ijrsvt ijrsvt approved these changes

Assignees

@ijrsvt ijrsvt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simon-mo @ijrsvt