Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] avoid system exit error #15687

Merged
merged 1 commit into from
May 13, 2021
Merged

Conversation

richardliaw
Copy link
Contributor

Why are these changes needed?

Use del instead of __ray_terminate__.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@richardliaw richardliaw marked this pull request as ready for review May 12, 2021 23:21
@richardliaw
Copy link
Contributor Author

@rkooo567 can you help verify this is the right way to terminate actors?

@rkooo567
Copy link
Contributor

This will work if we can ensure this is the last reference of this actor. Why not just using ray.kill? (do you need graceful shutdown?)

@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label May 13, 2021
@richardliaw
Copy link
Contributor Author

@rkooo567 yes, graceful termination is strictly necessary!

@richardliaw richardliaw merged commit ec27f9c into ray-project:master May 13, 2021
@richardliaw richardliaw deleted the tune-msg branch May 13, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants