[Tracing] Fix kwargs replacement #15742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-mo
commented
May 11, 2021
| @@ -179,6 +179,12 @@ def test_tracing_async_actor_start_workflow(cleanup_dirs, | |||
| assert async_actor_helper() | |||
|
|
|||
|
|
|||
| def test_wrapping(ray_start_init_tracing): | |||
| @ray.remote | |||
| def f(**_kwargs): | |||
There was a problem hiding this comment.
without the fix, error
E ValueError: wrong parameter order: variadic keyword parameter before keyword-only parameter
kathryn-zhou
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Originally the code didn't deal with variadic kwargs in the form of
**identifier. Theidentifierwas hard coded tokwargsoriginally but it should be any of them.Related issue number
Checks
scripts/format.shto lint the changes in this PR.