-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Explicitly set protobuf dependency version to 3.16.0 #15756
Conversation
Test failure in |
… bazel 4.0.0 Java protobuf dependency version is made to be consistent as well.
The remaining test failure is from
https://buildkite.com/ray-project/ray-builders-pr/builds/5213#a0ad406a-a457-47ec-9fbc-e341268a2686 There is also a CI build that timed out: https://travis-ci.com/github/ray-project/ray/jobs/505058849. CI builds from most other pull requests seem to use cached C++ build artifacts and spend little time on building C++ libraries, so the timeout is likely due to the new proto dependency requiring rebuilding many libraries. If this is the case, the CI build slow down should be transient. |
I will just re-run tests just in case. |
Thanks! The rerun of the tests seem to pass. I'm rerunning the build too. |
The failing flaky test is a known flaky test. Merging it. |
…ray with bazel 4.0.0 (ray-project#15756)" This reverts commit dce13d3.
Why are these changes needed?
This change is based on #14117 (comment) and #14728. It allows building ray with bazel 4.0.0 which is the latest version. By including the protobuf dependency explicitly, likely we avoid implicitly using an older version of protobuf.
Java protobuf dependencies are also updated to the same version, to avoid build failures.
Related issue number
Closes #14117
Checks
scripts/format.sh
to lint the changes in this PR.