Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] CQL: Bug fixes and OPE example added to test and offline_rl.py example. #15761

Merged
merged 10 commits into from
May 13, 2021

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented May 12, 2021

CQL: OPE example via learnt Q-function added to test and offline_rl.py example.

  • Fixed missing stats bug (stats_fn was not called anymore).
  • Fixed bug in offline_rl.py example script.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 changed the title [RLlib] CQL OPE example added to test and offline_rl.py example. [RLlib] CQL: Bug fixes and OPE example added to test and offline_rl.py example. May 12, 2021
@sven1977 sven1977 merged commit c4a3e15 into ray-project:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants