-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[serve] Rolling updates for user_config changes #15909
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
…-config-updates
…-config-updates
…-config-updates
…-config-updates
cc @caitengwei @liuyang-my This PR should help with common reloading models into running backend use case. |
simon-mo
approved these changes
May 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, just few small comments.
…-config-updates
…-config-updates
jiaodong
added
the
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
label
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Config updates may be slow and cause replicas to be unavailable while updating, so we should do rolling updates for these as well as code changes.
This PR uses the existing codepath for rolling updates but adds the hash of the user_config to the version used to check for required updates (this requires the user_config to be hashable, see
BackendVersion
implementation for details.When the user-provided version is mismatched, we perform the existing rolling update. When only the user_config is mismatched, we all the reconfigure method and wait for it to return. This transitions the replica back to the
STARTING_OR_UPDATING
state.Note that to maintain backwards compatibility this leaves the long poll client for backend configs in place, but once we remove the legacy
update_backend_config
codepath we can completely remove this from the backend_worker.Note that #15820 is dependent on this change so that we can properly wait for config changes to go through (i.e., endpoints to be available).
Related issue number
Closes #15136
Checks
scripts/format.sh
to lint the changes in this PR.