[release] convert tune release tests #15913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
May 17, 2021 11:08
krfricke
changed the title
|
This should be ready for review cc @richardliaw @amogkam |
|
Note: I ran the release tests for 1.4.0 on this branch (and they passed) |
richardliaw
reviewed
Jun 1, 2021
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| import ray | |||
| from ray.tune import run_experiments | |||
| from ray.cluster_utils import Cluster | |||
| import os | |||
There was a problem hiding this comment.
cc @sven1977 can you sign off on this?
richardliaw
reviewed
Jun 1, 2021
Comment on lines
+19
to
31
| # cluster = Cluster() | ||
| # for i in range(num_nodes): | ||
| # cluster.add_node( | ||
| # redis_port=6379 if i == 0 else None, | ||
| # num_redis_shards=num_redis_shards if i == 0 else None, | ||
| # num_cpus=10, | ||
| # num_gpus=0, | ||
| # resources={str(i): 2}, | ||
| # object_store_memory=object_store_memory, | ||
| # redis_max_memory=redis_max_memory, | ||
| # dashboard_host="0.0.0.0") | ||
| # ray.init(address=cluster.address) | ||
|
|
There was a problem hiding this comment.
I'm not quite sure about this change, but I'll open an issue to track this.
richardliaw
approved these changes
Jun 1, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
cc @richardliaw @amogkam
Related issue number
Checks
scripts/format.shto lint the changes in this PR.