[Client] Add ray.client().disconnect() #16021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijrsvt
added
the
core-interface-change-approval-required
|
cc @wuisawesome |
ijrsvt
commented
May 24, 2021
ijrsvt
commented
May 24, 2021
ijrsvt
commented
May 24, 2021
ijrsvt
commented
May 24, 2021
ijrsvt
commented
May 24, 2021
ijrsvt
commented
May 24, 2021
AmeerHajAli
approved these changes
May 25, 2021
There was a problem hiding this comment.
LGTM. should we make sure ray.util.disconnect() does not show up in the docs?
For Philipp's comment on returning a context class that we can call .disconnect() on, will that still support the case when the user forgot to assign the context class to a variable?
AmeerHajAli
added
the
@author-action-required
pcmoritz
reviewed
May 26, 2021
pcmoritz
reviewed
May 26, 2021
pcmoritz
reviewed
May 26, 2021
pcmoritz
reviewed
May 26, 2021
|
|
||
| server.stop(0) | ||
| subprocess.check_output("ray stop --force", shell=True) | ||
|
|
||
|
|
||
| @pytest.mark.skip() |
There was a problem hiding this comment.
Hmm, should this really be skipped?
There was a problem hiding this comment.
OOps, that was a debugging thing (I was trying to figure out why a test-test interaction was causing problems).
pcmoritz
reviewed
May 26, 2021
pcmoritz
reviewed
May 26, 2021
pcmoritz
approved these changes
May 26, 2021
ijrsvt
force-pushed
the
ray-client-disconnect
branch
from
0529523
to
bddc3c2
Compare
|
@ijrsvt should we merge this? |
|
I'm rerunning the tests because Travis failed (and re-running did not work).
…On Wed, May 26, 2021 at 7:04 AM Ameer Haj Ali ***@***.***> wrote:
@ijrsvt <https://github.com/ijrsvt> should we merge this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16021 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFC5KQSXBVGTK4YY77ZNCCDTPT5WZANCNFSM45NNSERQ>
.
|
|
@ijrsvt is this mergable? |
|
FYI This passed Travis! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
ray.util.disconnect()namespaces(by addingimport rayinstead ofimport).Related issue number
Checks
scripts/format.shto lint the changes in this PR.