Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tune] Place remote tune.run on node running the client server #16034

Merged
merged 4 commits into from
May 29, 2021
Merged

[Tune] Place remote tune.run on node running the client server #16034

merged 4 commits into from
May 29, 2021

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented May 24, 2021

Force placement of the remote tune.run call on the same node that is running the client server. This ensures that tune.run is called on a on-demand instance and the tune results can easily be accessed via ray attach or ray rsync-down.

See #15930 for more info

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@richardliaw
Copy link
Contributor

also cc @krfricke

@richardliaw richardliaw added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label May 25, 2021
@amogkam amogkam requested a review from richardliaw May 27, 2021 00:23
@amogkam amogkam removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label May 27, 2021
@amogkam amogkam requested a review from richardliaw May 27, 2021 17:32
@amogkam
Copy link
Contributor Author

amogkam commented May 29, 2021

This PR doesn’t affect Mac wheels. Going to merge this.

@amogkam amogkam merged commit 38b657c into ray-project:master May 29, 2021
@amogkam amogkam deleted the tune-client-head-placement branch May 29, 2021 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

@krfricke krfricke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amogkam @richardliaw @krfricke