Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Client][Proxy] Track Num Clients in the proxy #16038

Merged
merged 4 commits into from
May 26, 2021
Merged

[Client][Proxy] Track Num Clients in the proxy #16038

merged 4 commits into from
May 26, 2021

Conversation

ijrsvt
Copy link
Contributor

@ijrsvt ijrsvt commented May 24, 2021 •
edited
Loading

Why are these changes needed?

  • Fixes a bug where the num_clients corresponds to the specificServer. This is always ONE. This PR makes this proxy handle the num_clients.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ijrsvt ijrsvt force-pushed the track-num-clients-in-proxy branch from 0ce88c9 to 13401f0 Compare May 25, 2021 17:16
@fishbone
Copy link
Contributor

LGTM and thanks for the fixing!

@fishbone fishbone added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label May 26, 2021
@ijrsvt ijrsvt merged commit 3dbdd4e into ray-project:master May 26, 2021
@ijrsvt ijrsvt deleted the track-num-clients-in-proxy branch May 26, 2021 05:17
@AmeerHajAli AmeerHajAli added the release-blocker P0 Issue that blocks the release label May 26, 2021
@AmeerHajAli
Copy link
Contributor

@ijrsvt , is this a release blocker?

@ijrsvt
Copy link
Contributor Author

ijrsvt commented May 26, 2021

@AmeerHajAli Yes it is. I added it to the google sheets.

DmitriGekhtman pushed a commit that referenced this pull request May 26, 2021
@ijrsvt @DmitriGekhtman
[Client][Proxy] Track Num Clients in the proxy (#16038)
857dec2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fishbone fishbone fishbone approved these changes

Assignees

@AmeerHajAli AmeerHajAli

@fishbone fishbone

Labels
release-blocker P0 Issue that blocks the release tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ijrsvt @fishbone @AmeerHajAli