[Client][Proxy] Refactor RayClient Proxy to not use additional Threads. #16057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this be cherry-picked to ray 1.4? |
1 similar comment
|
Should this be cherry-picked to ray 1.4? |
|
@AmeerHajAli It is tested by the existing RayClient-Proxy tests. This is really just shuffling the internal implementation. |
AmeerHajAli
approved these changes
May 25, 2021
|
Failures unrelated (just a flaky Tune test). |
It is not necessary to be cherry picked for |
DmitriGekhtman
pushed a commit
that referenced
this pull request
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.