[Client] Make Client{ObjectRef,ActorRef} subclasses of their server-side counterparts #16110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwtian
added
the
@author-action-required
mwtian
changed the title
mwtian
force-pushed
the
ref
branch
2 times, most recently
from
f6e13dc
to
10ad72b
Compare
mwtian
removed
the
@author-action-required
mwtian
changed the title
|
coool, all the buildkite checks pass, will take a closer look soon |
ijrsvt
reviewed
May 31, 2021
ijrsvt
reviewed
May 31, 2021
Add basic unit tests.
ijrsvt
reviewed
Jun 1, 2021
|
@ericl , can you please review this? |
ijrsvt
approved these changes
Jun 1, 2021
|
Looks great, thanks for digging into how to fix this! |
|
Thanks @mwtian ! |
wuisawesome
pushed a commit
to wuisawesome/ray
that referenced
this pull request
Jun 2, 2021
…server-side counterparts (ray-project#16110)" This reverts commit f14f197.
mwtian
added a commit
to mwtian/ray
that referenced
this pull request
Jun 3, 2021
…f their server-side counterparts (ray-project#16110)" (ray-project#16196)" This reverts commit 9942505.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This avoids code duplication and user confusion when handling Client{ObjectRef,ActorRef}. Users just need to know about ObjectRef and ActorID regardless of whether the logic runs in Ray worker or with Ray client.
Compared to current implementations of Client{ObjectRef,ActorRef}, the differences of the new implementations are the additional methods from the parents
ObjectRefandActorID. No additional differences are intended.Related issue number
Closes #14042
Checks
scripts/format.shto lint the changes in this PR.