Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SGD] Ray Client Support and tests #16111

Merged
merged 6 commits into from
Jun 1, 2021
Merged

[SGD] Ray Client Support and tests #16111

merged 6 commits into from
Jun 1, 2021

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented May 27, 2021 •
edited
Loading

Closes #9264

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

richardliaw
richardliaw approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@richardliaw
Copy link
Contributor

test failures unrelated.

@richardliaw richardliaw merged commit 65f1d67 into ray-project:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[raysgd] Method for saving remote GPU checkpoint on CPU head
2 participants
@amogkam @richardliaw