Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] DDPG torch GPU bug. #16133

Merged
merged 2 commits into from
May 28, 2021
Merged

[RLlib] DDPG torch GPU bug. #16133

merged 2 commits into from
May 28, 2021

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented May 28, 2021 •
edited
Loading

DDPG torch GPU crashes due to a device mismatch error in ddpg_torch_model.py.

Also see this issue here:
#16134

Why are these changes needed?

Issue #16134

Related issue number

Closes #16134

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 requested a review from richardliaw May 28, 2021 16:28
richardliaw
richardliaw approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rllib tests seem to fail

@sven1977 sven1977 merged commit 5fe3486 into ray-project:master May 28, 2021
@sven1977
Copy link
Contributor Author

fixed.

DmitriGekhtman pushed a commit that referenced this pull request May 30, 2021
@sven1977 @DmitriGekhtman
[RLlib] DDPG torch GPU bug. (#16133)
6f8b754
@sven1977 sven1977 deleted the ddpg_torch_gpu_problem branch June 2, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RLlib] DDPG PyTorch not working on GPU.
2 participants
@sven1977 @richardliaw