Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rllib] add tests for examples using ray client #16271

Merged
merged 2 commits into from
Jun 9, 2021

Conversation

matthewdeng
Copy link
Contributor

Why are these changes needed?

Adding tests for RLLib using Ray Client to connect. Functionality being tested comes from the following key example flows:

  1. custom_train_fn
  2. cartpole_lstm
  3. custom_experiment

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks good to me! Will wait for @sven1977 to give final approval.

Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Thanks for these tests @matthewdeng !

rllib/tests/test_client.py Outdated Show resolved Hide resolved
@amogkam amogkam merged commit 138b273 into ray-project:master Jun 9, 2021
@matthewdeng matthewdeng deleted the rllib-rayclient branch June 9, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants