[Core] [runtime env] Merge actor/task's runtime env with JobConfig's runtime env #16378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
architkulkarni
added
@author-action-required
architkulkarni
removed
@author-action-required
architkulkarni
changed the title
edoakes
approved these changes
Jun 16, 2021
6 tasks
architkulkarni
added
the
tests-ok
DmitriGekhtman
pushed a commit
that referenced
this pull request
Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Previously, the runtime env specified per-task or per-actor would override the one specified in the JobConfig. This PR makes it so that the runtime env is merged instead.
Related issue number
Closes #16294
Checks
scripts/format.shto lint the changes in this PR.