[Tune] Add soft imports test #16450
Merged
[Tune] Add soft imports test #16450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardliaw
reviewed
Jun 15, 2021
| """Tests whether it's possible to use Ray Tune without soft dependencies | ||
| """ | ||
|
|
||
| def testSoftImports(self): |
There was a problem hiding this comment.
nice! can you also check that these libraries are not available? i.e., use importlib to check for the availability of libraries, just incase someone accidentally introduces a regression that downloads extra dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Tune Searchers work by providing a wrapper around an external library. Those libraries must be soft dependencies. In the past, there were a couple of instances of a soft dependency being imported as a hard one by mistake. This test will check whether all Searchers and Schedulers have correctly imported dependencies.
Also fixes an example of the issue this test would check for that was caught by it in the Zoopt searcher.
This PR adds a new buildkite build - it's possible it can be done in one build, but I am not sure what would be the best way.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.