Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job timestamp should always be in milliseconds (fixed) #16548

Merged
merged 16 commits into from
Jun 19, 2021
Merged

Job timestamp should always be in milliseconds (fixed) #16548

merged 16 commits into from
Jun 19, 2021

Conversation

wuisawesome
Copy link
Contributor

@wuisawesome wuisawesome commented Jun 18, 2021 •
edited
Loading

Why are these changes needed?

This PR always sets the job related timestamps in GCS to avoid timing inconsistencies and race conditions.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Alex Wu added 15 commits May 21, 2021 01:07
.
8d3891d
Merge branch 'master' of github.com:wuisawesome/ray
60ca1a4
Merge branch 'master' of github.com:ray-project/ray
d9f823b
Merge branch 'master' of github.com:ray-project/ray into master
a890877
Merge branch 'master' of github.com:ray-project/ray
c8a4e9d
Merge branch 'master' of github.com:wuisawesome/ray into master
3fe9c83
Merge branch 'master' of github.com:ray-project/ray into master
bb9d6ab
Merge branch 'master' of github.com:ray-project/ray into master
561661e
Merge branch 'master' of github.com:ray-project/ray into master
1d8beac
Merge branch 'master' of github.com:ray-project/ray into master
55c66da
Merge branch 'master' of github.com:ray-project/ray
72ad03e
Merge branch 'master' of github.com:ray-project/ray
fdd95ea
Revert "Revert "Job timestamp should always be in milliseconds (ray-p…
0551d4a 
…roject#16455)" (ray-project#16545)"

This reverts commit 5030ed8.
.
9121e14
.
e63b7cc
@wuisawesome wuisawesome changed the title Job timestamp should always be in milliseconds #16455 Job timestamp should always be in milliseconds (fixed) Jun 18, 2021
@wuisawesome
Copy link
Contributor Author

cc @architkulkarni

@AmeerHajAli
Copy link
Contributor

Can we make sure this is in 1.4.1?
Also, CC @ijrsvt

ijrsvt
ijrsvt approved these changes Jun 19, 2021
View reviewed changes
Copy link
Contributor

@ijrsvt ijrsvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wuisawesome
Copy link
Contributor Author

Failing tests look flakey. Merging.

@wuisawesome wuisawesome merged commit 319d4fb into ray-project:master Jun 19, 2021
DmitriGekhtman pushed a commit that referenced this pull request Jun 20, 2021
@DmitriGekhtman
Job timestamp should always be in milliseconds (fixed) (#16548)
c3f7bde 
* .

* Revert "Revert "Job timestamp should always be in milliseconds (#16455)" (#16545)"

This reverts commit 5030ed8.

* .

* .

* .

Co-authored-by: Alex Wu <alex@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijrsvt ijrsvt ijrsvt approved these changes

Assignees

@AmeerHajAli AmeerHajAli

@ijrsvt ijrsvt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wuisawesome @AmeerHajAli @ijrsvt