Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] explicitly raising tune import Error “[tune]” #16575

Merged
merged 3 commits into from
Jul 12, 2021

Conversation

rajagurunath
Copy link
Contributor

Why are these changes needed?

Explicitly raise ImportError for better USER Experience

Summary

Error out the dependency missing Error aka ImportError, instead of silently failing with different error which introduces unnecessary confusion for the end-user

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@architkulkarni architkulkarni changed the title explicitly raising tune import Error “[tune]” [tune] explicitly raising tune import Error “[tune]” Jun 24, 2021
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@richardliaw richardliaw merged commit e3966f5 into ray-project:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants