Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracing] Do not wrap when tracing is not enabled #16607

Merged
merged 10 commits into from Jul 16, 2021

Conversation

kira-lin
Copy link
Contributor

@kira-lin kira-lin commented Jun 22, 2021

Why are these changes needed?

When using cross language call, because defined remote functions are wrapped by tracing helper, the module_name in function_descriptor will become tracing_helper, and thus fail to import.

Related issue number

Closes #16606

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@kira-lin
Copy link
Contributor Author

Hi @simon-mo could you please take a look?

@kira-lin
Copy link
Contributor Author

kira-lin commented Jul 5, 2021

The PR now pass test_tracing. The other test failures seems not related

@simon-mo simon-mo merged commit 6d9fb42 into ray-project:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tracing] Cross language call failed even when tracing is not enabled
2 participants