Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] move to local parameter registry for tune.with_parameters() #16611

Merged
merged 1 commit into from
Jun 23, 2021
Merged

[tune] move to local parameter registry for tune.with_parameters() #16611

merged 1 commit into from
Jun 23, 2021

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

See #16609 - running tune.with_parameters() twice in the same script but different ray sessions crashes.

cc @amogkam

Related issue number

Closes #16609

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke krfricke mentioned this pull request Jun 22, 2021
Closed
@krfricke krfricke requested a review from amogkam June 22, 2021 09:20
amogkam
amogkam approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amogkam
Copy link
Contributor

amogkam commented Jun 23, 2021

Failing tests have been fixed on master. Going to merge.

@amogkam amogkam merged commit a1765ac into ray-project:master Jun 23, 2021
@krfricke krfricke deleted the with-parameters branch June 28, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amogkam amogkam amogkam approved these changes

Assignees

@amogkam amogkam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tune] Multiple tune.with_parameters calls crashes Ray
2 participants
@krfricke @amogkam