[Serve] Fix HTTP headers #16647
Merged
[Serve] Fix HTTP headers #16647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-mo
commented
Jun 23, 2021
| FastAPIApp.deploy() | ||
|
|
||
| resp = requests.get("http://localhost:8000/f") | ||
| assert resp.cookies.get_dict() == {"a": "b", "c": "d"} |
There was a problem hiding this comment.
verified it failed without the fix
edoakes
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
@nikitavemuri found a bug where multiple headers with the same key will override each other, for example, with
we will only send
Set-Cookie b. This PR fixes the issue when we translate ASGI protocol to starlette response.Related issue number
Checks
scripts/format.shto lint the changes in this PR.