Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Fix ModelV2 custom metrics for torch. #16734

Merged
merged 10 commits into from
Jul 1, 2021
Merged

[RLlib] Fix ModelV2 custom metrics for torch. #16734

merged 10 commits into from
Jul 1, 2021

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jun 29, 2021 •
edited
Loading

Fix ModelV2 custom metrics for torch.

  • TorchModelV2's metrics method was called, but metrics returned from there were not reported in Trainer.train() output.
  • Unified some more the returned metrics structures for tf and torch.
  • Soft-renamed 2 example scripts.

Why are these changes needed?

Closes #16472

Related issue number

Issue #16472

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 mentioned this pull request Jun 29, 2021
Closed
2 tasks
@sven1977
Copy link
Contributor Author

Issue: #16472

@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jul 1, 2021
@sven1977 sven1977 merged commit 7eb1a29 into ray-project:master Jul 1, 2021
This was referenced Jul 7, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelzhiluo michaelzhiluo michaelzhiluo approved these changes

Assignees

@michaelzhiluo michaelzhiluo

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[rllib] Metrics from Custom Torch Model not present in ResultDict
2 participants
@sven1977 @michaelzhiluo