Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve] Update kubernetes docs to specify a namespace #16786

Merged
merged 2 commits into from
Jul 1, 2021
Merged

[serve] Update kubernetes docs to specify a namespace #16786

merged 2 commits into from
Jul 1, 2021

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Jun 30, 2021

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

simon-mo
simon-mo approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we clarify this namespace has nothing to do with K8s namespace?

@edoakes edoakes merged commit d69e51f into ray-project:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees

@jiaodong jiaodong

@simon-mo simon-mo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edoakes @simon-mo @jiaodong