[Autoscaler] Use NetworkInterfaces parameter to launch instances.

[xcharleslin]

Why are these changes needed?

This PR allows launching in subnets where public IP assignments are enabled but off by default.

It does this by:

• Specifying NetworkInterfaces.AssociatePublicIpAddress = True
• Moving SubnetId, SecurityGroupIds into NetworkInterfaces (required by boto when using NetworkInterfaces)

Related issue number

Partial resolution to #16815.

Checks

• I've run scripts/format.sh to lint the changes in this PR.
• I've included any doc changes needed for https://docs.ray.io/en/master/.
• I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
• Testing Strategy
  • Unit tests
  • Release tests
  • This PR is not tested :(

[DmitriGekhtman]

There's also a lint error -- In case you haven't used it before, Ray lint check/format can be done locally with ray/scripts/ci.sh
You can also install pre-push lint hooks with ray/setup_hooks.sh.

Also, it would be good to do a spot-check that you can launch a ray cluster with ray up with these changes.

Thanks for making this fix!

[DmitriGekhtman]

should check with ray up aws/example-full.yaml before merge

[wuisawesome]

Can one of you confirm it works, then add the tests-ok label (or ping me) and I will merge?

[DmitriGekhtman]

Can one of you confirm it works, then add the tests-ok label (or ping me) and I will merge?

I'll go ahead and do that

[DmitriGekhtman]

It works. @wuisawesome ready to merge