[rllib] Improve test learning check, fix flaky two step qmix #16843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
two step qmix was previously very flaky.
The core test has been fixed by providing a seed. For this to work, passing the seed in a
GroupAgentWrapper
had to be enabled.Secondly, learning test checks recently used
analysis.trials[0].last_result
to check for success. This PR introduces a change, that collects all trials results and picks the best achieved reward. This means that the test will always succeed if at least one of the trials achieved the desired performance.cc @ericl, @sven1977 and @richardliaw for your opinion on this change.
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.