[rllib] Enhancements to Input API for customizing offline datasets #16957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardliaw
reviewed
Jul 8, 2021
richardliaw
reviewed
Jul 8, 2021
Hi, thanks for the review! I don't have a machine on hand to run |
|
Don’t worry about format.sh, I can run that for you. As for tests, there
should be some in rllib/. Let me take a look…
…On Thu, Jul 8, 2021 at 4:03 PM Julius Frost ***@***.***> wrote:
Hi, thanks for the contribution! :)
The changes look good to me (I just had a quick look). Did you already run
format.sh? And do you still plan on writing some test(s) to test the new
functionality?
Hi, thanks for the review! I don't have a machine on hand to run format.sh.
Also, I'm not sure how to create tests for the offline API, are there any
examples or tests I can modify?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#16957 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCRZZMABVZTL2HN4LWMHKDTWYVFXANCNFSM47766ZBA>
.
|
|
Maybe look at test_io.py in rllib/tests?
…On Thu, Jul 8, 2021 at 4:33 PM Richard Liaw ***@***.***> wrote:
Don’t worry about format.sh, I can run that for you. As for tests, there
should be some in rllib/. Let me take a look…
On Thu, Jul 8, 2021 at 4:03 PM Julius Frost ***@***.***>
wrote:
> Hi, thanks for the contribution! :)
>
> The changes look good to me (I just had a quick look). Did you already
> run format.sh? And do you still plan on writing some test(s) to test the
> new functionality?
>
> Hi, thanks for the review! I don't have a machine on hand to run
> format.sh. Also, I'm not sure how to create tests for the offline API,
> are there any examples or tests I can modify?
>
> —
> You are receiving this because you were assigned.
>
>
> Reply to this email directly, view it on GitHub
> <#16957 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABCRZZMABVZTL2HN4LWMHKDTWYVFXANCNFSM47766ZBA>
> .
>
|
|
Added tests. Should be ready to go if it passes |
richardliaw
reviewed
Jul 9, 2021
|
got it!
…On Fri, Jul 9, 2021 at 4:27 PM Julius Frost ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In rllib/examples/custom_input_api.py
<#16957 (comment)>:
> + if not os.path.exists(args.input_files):
+ # This script runs in the ray/rllib/examples dir.
+ rllib_dir = Path(__file__).parent.parent
+ input_dir = rllib_dir.absolute().joinpath(args.input_files)
+ args.input_files = str(input_dir)
This was present in other examples so I just copied it over. It seems like
it is unnecessary though.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#16957 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCRZZLCAGINRAMFIAI75ELTW6AWXANCNFSM47766ZBA>
.
|
|
Tests are passing! |
|
@michaelzhiluo @sven1977 I'll merge this for now; please take a look when convenient! |
|
@juliusfrost great work here :) |
jiaodong
pushed a commit
that referenced
this pull request
Jul 11, 2021
…16957) Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR makes useful enhancements to the Input API so that it is much easier to customize offline datasets.
It implements the following:
Related issue number
Checks
scripts/format.shto lint the changes in this PR.I would love feedback from @richardliaw @sven1977 @michaelzhiluo