[Core] fix the bug where we failed to read spilled object whose size is greater than max(int32_t) #17187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scv119
force-pushed
the
fix-spill-parsing
branch
from
73b597f
to
813efca
Compare
scv119
changed the title
ericl
approved these changes
Jul 19, 2021
ericl
added
the
@author-action-required
rkooo567
approved these changes
Jul 19, 2021
|
good to know atoi is using int32.. |
jiaodong
pushed a commit
that referenced
this pull request
Jul 21, 2021
(cherry picked from commit b26fcd3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we use
stoito parse spilled url which only handles int32_t. change it tostollwhich handles long long, which is at least int64_t in C++11.https://en.cppreference.com/w/cpp/string/basic_string/stol
https://en.cppreference.com/w/cpp/language/types
Test plan: