Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runtime env] [Serve] Fix error when uris field is None #18874

Merged
merged 4 commits into from
Sep 24, 2021

Conversation

architkulkarni
Copy link
Contributor

Why are these changes needed?

When Ray Serve starts a deployment, it overwrites the uris field with the uris from the JobConfig. However, if there are no uris, it sets runtime_env[uris] to None, which causes an error later on when we try to iterate through runtime_env[uris]. This PR handles the None case and adds a test.

Related issue number

Closes #18865

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@architkulkarni architkulkarni added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Sep 24, 2021
@architkulkarni
Copy link
Contributor Author

mac-small-and-large timed out during basic tests, and wheels-and-jars failed even though the post-wheel-build tests succeeded (which implies the wheels successfully built there.) Retrying these tests, let's see what happens

@architkulkarni architkulkarni removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Sep 24, 2021
@edoakes edoakes merged commit fbf5f5d into ray-project:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Serve] [runtime env] [Bug] Serve does not work with runtime env
3 participants