Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] fix tune list-trials metric #18914

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

Fetching result dataframes using metric and mode gives unexpected results and only works with rllib trainables.

Instead we should present the last observed results and not require any particular metric.

Related issue number

Follow-up to #18850
Closes #18740

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke krfricke merged commit 6be87a3 into ray-project:master Sep 28, 2021
@krfricke krfricke deleted the tune/list_trials branch September 28, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] tune list-trials crashes when trial report does not contain"episode_reward_mean"
2 participants