add msvcp140.dll to the wheel on windows

[mattip]

Why are these changes needed?

Closes #13293. As described in the issue, on a minimal windows image the support dll msvcp140.dll is needed to load _raylet.pyd.

Related issue number

Checks

• I've run scripts/format.sh to lint the changes in this PR.
• I've included any doc changes needed for https://docs.ray.io/en/master/.
• I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
• Testing Strategy
  • Unit tests
  • Release tests
  • This PR is not tested :(

[richardliaw]

Suggested change

	print('copy_file uses', build_ext.build_lib, ROOT_DIR)
	shutil.copy(r'c:\Windows\system32\msvcp140.dll',
	os.path.join(build_ext.build_lib, 'ray'))
	print("copy_file uses", build_ext.build_lib, ROOT_DIR)
	shutil.copy(r"c:\Windows\system32\msvcp140.dll",
	os.path.join(build_ext.build_lib, "ray"))

[richardliaw]

We use double quotes for literals

[mattip]

thanks, fixed and removed the debug print

[mattip]

On the one hand this is a very small change, on the other it is a bit obscure how the dll ends up in the wheel. I guess git grep msvcp140 will find it, is that discoverable enough or should I make a copy_system_dlls() function to emphasize it?

[richardliaw]

Explicit emphasis and comments will help maintainers moving forward!

…

On Sun, Oct 3, 2021 at 2:27 PM Matti Picus ***@***.***> wrote: On the one hand this is a very small change, on the other it is a bit obscure how the dll ends up in the wheel. I guess git grep msvcp140 will find it, is that discoverable enough or should I make a copy_system_dlls() function to emphasize it? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#19062 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCRZZKXWGLGRXD4JJEQOIDUFDDFVANCNFSM5FH2F2ZA> .

[pcmoritz]

Thanks for doing this, this is great! Looks like the windows tests failed for unrelated reasons, re-running them.

[pcmoritz]

@mattip Looks like there is an unrelated doc building failure, can you merge master into this PR? that should make it go away!

[mattip]

rebased off master