Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush stdout/stderr to avoid empty log in detached docker when start block #19546

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

chenk008
Copy link
Contributor

@chenk008 chenk008 commented Oct 20, 2021

Why are these changes needed?

This change flushes stdout/stderr, so that the detached docker container can show the log.

Without this change:
image

With this change:
image

Related issue number

Closes #19545

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@DmitriGekhtman DmitriGekhtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.
CI looks unhappy -- would you mind rebasing or merging master and retrying?

@chenk008
Copy link
Contributor Author

@DmitriGekhtman Thanks. I have merged master, I think windows-msvc failure is not related to this PR.

@DmitriGekhtman DmitriGekhtman merged commit b65aca9 into ray-project:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Ray start --block in detached container not print essential log
2 participants