Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] Remove magic results (e.g. config) before calculating trial result metrics #19583

Merged
merged 2 commits into from
Oct 21, 2021
Merged

[tune] Remove magic results (e.g. config) before calculating trial result metrics #19583

merged 2 commits into from
Oct 21, 2021

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

Related issue number

Addresses the application-layer memory issue in #19309 (comment)

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke krfricke mentioned this pull request Oct 21, 2021
Closed
2 tasks
@krfricke krfricke requested a review from Yard1 October 21, 2021 14:16
Yard1
Yard1 reviewed Oct 21, 2021
View reviewed changes
python/ray/tune/trial.py Outdated Show resolved Hide resolved
python/ray/tune/tests/test_experiment_analysis_mem.py Outdated Show resolved Hide resolved
xwjiang2010
xwjiang2010 approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@xwjiang2010 xwjiang2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I also had one ready for review. I will drop that then.

@krfricke krfricke merged commit 7d8ea5e into ray-project:master Oct 21, 2021
@krfricke krfricke deleted the tune/remove-magic-metrics branch October 21, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

@xwjiang2010 xwjiang2010 xwjiang2010 approved these changes

@matthewdeng matthewdeng Awaiting requested review from matthewdeng matthewdeng is a code owner

Assignees

@matthewdeng matthewdeng

@Yard1 Yard1

@xwjiang2010 xwjiang2010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@krfricke @Yard1 @xwjiang2010 @matthewdeng