-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ready for review] Initial http jobs server on head node #19657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Do you plan to use pydantic types for validating inputs?
dashboard/modules/job/job_head.py
Outdated
if not ray.is_initialized(): | ||
ray.init(address="auto") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we centralize this ray.init logic to one place? Maybe make it a decorator?
Also, we should use some kind of internal namespace ("_ray_internal_jobs"?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
decorator sounds great, looks like ray.init() has to happen at api calls (run() didn't work either) but at least only called once.
internal namespace sounds great too !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will refuse to ship job server without pydantic type checks so this has to be included
Windows failures look unrelated and same tests also have failures on master. |
After syncing with Ant this week, they confirmed this folder is not used anymore as they use internal implementation only. So in this PR we can just strip it to the minimum and redo a simple http server.
Changes
class JobHead(dashboard_utils.DashboardHeadModule):
leftTest plan
Closes #19413
Checks
scripts/format.sh
to lint the changes in this PR.