-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [Placement Group] resizing placement group feature part1: dynamic add bundles. #19753
[WIP] [Placement Group] resizing placement group feature part1: dynamic add bundles. #19753
Conversation
|
cc @edoakes |
sorry, Sang, @rkooo567 , The pub-sub module was refactored too much, Do you know how can I configure enable Redis pub-sub for the test case? |
Redis pubsub is no longer supported. Ray only supports external Redis KV now. I guess we need a guide for adding new topics to Ray pubsub. |
Hey @clay4444 how will this PR work with the autoscaler? Can we make sure we understand the plan for how this will work with autoscaling before merging? |
This is an example of adding a channel to Ray pubsub: https://github.com/ray-project/ray/pull/20075/files |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
It's not stale |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message. Please feel free to reopen or open a new issue if you'd still like it to be addressed. Again, you can always ask for help on our discussion forum or Ray's public slack channel. Thanks again for opening the issue! |
Why are these changes needed?
resizing placement group feature part1: dynamically add bundles.
the design doc API proposal
Note that there is a new update at the end of the document.
Python integration tests will be added later.
Related issue number
Closes #16403
Checks
scripts/format.sh
to lint the changes in this PR.