Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] remove TrialExecutor.resume_trial. #21225

Merged
merged 1 commit into from Jan 3, 2022
Merged

[tune] remove TrialExecutor.resume_trial. #21225

merged 1 commit into from Jan 3, 2022

Conversation

xwjiang2010
Copy link
Contributor

@xwjiang2010 xwjiang2010 commented Dec 21, 2021 •
edited

Dangling API.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@xwjiang2010 xwjiang2010 added this to the Tune Tech Debt Reduction milestone Dec 21, 2021
krfricke
krfricke approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krfricke krfricke merged commit c18caa4 into ray-project:master Jan 3, 2022
@xwjiang2010 xwjiang2010 deleted the remove_resume_trial branch July 26, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke krfricke approved these changes

Assignees

@krfricke krfricke

Labels
None yet
Projects
None yet
Milestone
Tune Tech Debt Reduction
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xwjiang2010 @krfricke