Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Issue 20920 (partial solution): contrib/MADDPG + pettingzoo coop-pong-v4 not working #21452

Merged
merged 1 commit into from Jan 10, 2022
Merged

[RLlib] Issue 20920 (partial solution): contrib/MADDPG + pettingzoo coop-pong-v4 not working #21452

merged 1 commit into from Jan 10, 2022

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jan 7, 2022 •
edited

Issue 20920 (partial solution): contrib/MADDPG + pettingzoo coop-pong-v4 not working

Why are these changes needed?

#20920

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 requested a review from gjoliver January 7, 2022 11:30
@sven1977 sven1977 mentioned this pull request Jan 7, 2022
Closed
gjoliver
gjoliver approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@gjoliver gjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty nice!

@sven1977 sven1977 merged commit b10d553 into ray-project:master Jan 10, 2022
@sven1977 sven1977 deleted the issue_20920_maddpg_pettingzoo branch June 2, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjoliver gjoliver gjoliver approved these changes

Assignees

@gjoliver gjoliver

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sven1977 @gjoliver