Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Issue 21629: Video recorder env wrapper not working. Added test case. #21670

Merged
merged 5 commits into from Jan 24, 2022
Merged

[RLlib] Issue 21629: Video recorder env wrapper not working. Added test case. #21670

merged 5 commits into from Jan 24, 2022

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jan 18, 2022 •
edited

Issue 21629: Video recorder env wrapper not working.

  • Added test case that checks actual mp4 files to be created.

Why are these changes needed?

Related issue number

Issue #21629

Closes #21629

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
Copy link
Contributor Author

@simonsays1980 ^ :)

@sven1977 sven1977 mentioned this pull request Jan 18, 2022
Closed
2 tasks
@sven1977 sven1977 requested review from avnishn and removed request for gjoliver January 19, 2022 08:50
@sven1977 sven1977 assigned avnishn and unassigned gjoliver Jan 19, 2022
avnishn
avnishn reviewed Jan 19, 2022
View reviewed changes
Copy link
Contributor

@avnishn avnishn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment that I think needs to be addressed before merging. WDYT?

rllib/env/base_env.py
return env.to_base_env()
return env.to_base_env(
make_env=make_env,
num_envs=num_envs,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol whoops my bad

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this adds any speedup

rllib/env/tests/test_record_env_wrapper.py Show resolved Hide resolved
rllib/examples/env/mock_env.py Show resolved Hide resolved
rllib/examples/env/mock_env.py Show resolved Hide resolved
@sven1977 sven1977 merged commit c288b97 into ray-project:master Jan 24, 2022
@mickelliu mickelliu mentioned this pull request Feb 9, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avnishn avnishn avnishn left review comments

@gjoliver gjoliver gjoliver approved these changes

Assignees

@avnishn avnishn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using the Monitor wrapper from gym leads to an exception in poll() [Bug]
3 participants
@sven1977 @gjoliver @avnishn