[Datasets] Fix spread resource prefix tasks with no CPU requested. #22017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scv119
approved these changes
Jan 31, 2022
| resources={"foo": 100}, _system_config={"max_direct_call_object_size": 0} | ||
| ) | ||
| cluster.add_node(resources={"bar:1": 100}) | ||
| cluster.add_node(resources={"bar:2": 100}, num_cpus=0) |
There was a problem hiding this comment.
Doesn't matter for this test. This test is ensuring that a task with the spread resource prefix and with num_cpus=0 is able to be placed on a node with 0 CPUs advertised, so it's orthogonal to whether or not the node has any GPUs.
|
Note that this fixes the |
ericl
approved these changes
Jan 31, 2022
ericl
approved these changes
Jan 31, 2022
ericl
added
the
@author-action-required
clarkzinzow
added
tests-ok
|
Datasets tests ok, ready to merge. |
scv119
pushed a commit
that referenced
this pull request
Feb 9, 2022
…22017) When applying the `_spread_resouce_prefix` hack, don't make the CPU resource a required resource when `num_cpus=0` is requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying the
_spread_resouce_prefixhack, don't make the CPU resource a required resource whennum_cpus=0is requested.Related issue number
Closes #22003
Checks
scripts/format.shto lint the changes in this PR.