Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[train] add FAQ #22757

Merged
merged 4 commits into from
Apr 4, 2022
Merged

[train] add FAQ #22757

merged 4 commits into from
Apr 4, 2022

Conversation

matthewdeng
Copy link
Contributor

@matthewdeng matthewdeng commented Mar 2, 2022

Why are these changes needed?

Adding a FAQ page. Currently has some basic questions that have come up in the past.

Explaining how to use Matplotlib due to threading in the distributed training function.

Related issue number

Closes #22081

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@@ -1240,3 +1240,20 @@ Backwards Compatibility with Ray SGD
------------------------------------

If you are currently using :ref:`RaySGD <sgd-index>`, you can migrate to Ray Train by following: :ref:`sgd-migration`.

FAQ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewdeng can we start an actual faq.rst page like Tune has? Please look at Tune for structure etc.

This is not necessarily true for Train, but a lot of our user guides are filled with minor FAQ-like sections.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, certainly. I had originally decided against creating a separate page in this PR since I wasn't sure how the reader would react if there was just one question listed.

Are there any sections in the existing Train User Guide that you feel should be converted to FAQ? Or any other questions you think are worth answering to start it off?

Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but will defer to @maxpumperla and @worldveil for final approval! Let me know when it's ready to merge!

@amogkam
Copy link
Contributor

amogkam commented Mar 11, 2022

@matthewdeng do you think this is ready to merge? Should we get another review from @maxpumperla or @worldveil?

@matthewdeng matthewdeng changed the title [train] add FAQ for matplotlib [train] add FAQ Apr 4, 2022
@matthewdeng matthewdeng requested a review from amogkam April 4, 2022 16:59
@amogkam amogkam merged commit a12f5ff into ray-project:master Apr 4, 2022
edoakes pushed a commit to edoakes/ray that referenced this pull request Apr 7, 2022
Adding a FAQ page. Currently has some basic questions that have come up in the past.

Explaining how to use Matplotlib due to threading in the distributed training function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ray Train / Ray Tune fails with Matplotlib
4 participants