[serve] Implement serve.build
#23232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiaodong
reviewed
Mar 17, 2022
python/ray/serve/api.py
Outdated
|
|
||
| parameter_group.append(deployment_parameters) | ||
|
|
||
| internal_get_global_client().deploy_group(parameter_group, _blocking=blocking) |
There was a problem hiding this comment.
does deploy_group return a RayServeHandle as func signature says ?
There was a problem hiding this comment.
Ah, not it doesn't. However, it also doesn't look like anything is using the public deploy_group, so I'll remove it.
jiaodong
reviewed
Mar 24, 2022
| with open(output_path, "w") as f: | ||
| app.to_yaml(f) | ||
| else: | ||
| print(app.to_yaml(), end="") |
There was a problem hiding this comment.
not for this PR, but as a follow up it will be much more actionable to print other instructions for next step, such as providing a file path, or calling other clis to deployment the yaml file.
jiaodong
approved these changes
Mar 24, 2022
simon-mo
approved these changes
Mar 24, 2022
| attr_name = full_path[last_period_idx + 1 :] | ||
| module_name = full_path[:last_period_idx] | ||
|
|
||
| if ":" in full_path: |
There was a problem hiding this comment.
nit: check only one ":" exists?
There was a problem hiding this comment.
I added a conditional to handle this.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The Serve REST API relies on YAML config files to specify and deploy deployments. This change introduces
serve.build()andserve build, which translate Pipelines to YAML files.Related issue number
Closes #23137, closes #23138, and closes #23139.
Checks
scripts/format.shto lint the changes in this PR.Applications' behavior.