[RLlib] Slate-Q +GPU torch bug fix. #23464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eq_torch_gpu_fix
avnishn
approved these changes
Mar 24, 2022
|
Yes, this was tested on a GPU machine in the product. |
gjoliver
reviewed
Mar 24, 2022
| # action.shape: [B, S] | ||
| actions = train_batch[SampleBatch.ACTIONS] | ||
|
|
||
| observation = convert_to_torch_tensor( |
There was a problem hiding this comment.
just a thought, should we fix this in a more generic way for dict obs space?
not sure if this is also happening to other agents, and they just don't use strange looking obs by default.
| @@ -487,7 +487,7 @@ slateq-interest-evolution-recsim-env: | |||
| convert_to_discrete_action_space: false | |||
| seed: 0 | |||
|
|
|||
There was a problem hiding this comment.
framework was changed from torch to tf.
do you want to change it back? or run both?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slate-Q +GPU torch bug fix.
get_interceptor. This is probably due to the nested dict structure (preprocessor off for SlateQ) arriving in the loss functionWhy are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.