Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] [serve] Extended Gradio notebook example for Ray Serve deployments #23494

Merged
merged 4 commits into from
Apr 27, 2022

Conversation

maxpumperla
Copy link
Contributor

@maxpumperla maxpumperla commented Mar 25, 2022

Signed-off-by: Max Pumperla max.pumperla@googlemail.com

New Serve example showing how to hook into Gradio interfaces to easily visualise deployments.

Notebook preview

Screenshot 2022-03-25 at 16 23 30

Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla maxpumperla changed the title [docs] Gradio notebook [docs] [serve] Extended Gradio notebook example for Ray Serve deployments Mar 25, 2022
@maxpumperla
Copy link
Contributor Author

maxpumperla commented Mar 25, 2022

@edoakes not entirely sure what you mean by an "integration" in #23390. Assuming we can figure out input and output types of Serve deployments and map them automatically to gr.inputs and gr.outputs, then that's actually easy. Otherwise, I think an example like this is all we can hope for.

@maxpumperla
Copy link
Contributor Author

Screenshot 2022-03-25 at 16 33 14

@@ -0,0 +1,364 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we do myst instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with myst the problem is that we don't get the Colab launch button (and binder is also strange in terms of integration). So I'd prefer ipynb, like in Tune.

@simon-mo
Copy link
Contributor

content looks good. We can have exactly the same thing with Streamlit

@maxpumperla
Copy link
Contributor Author

@simon-mo thanks. yeah, was thinking the same re: streamlit, which is actually more complex. Might be good for a more involved example.

@maxpumperla maxpumperla self-assigned this Mar 29, 2022
Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are two simple items blocking merge:

Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@maxpumperla
Copy link
Contributor Author

@simon-mo removed the checkpoints, forgot about that. Never heard about that image repo before. are we sure this is blocking?

Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
@simon-mo
Copy link
Contributor

merging masters to re-run the tests

@simon-mo simon-mo merged commit 553c8a8 into master Apr 27, 2022
@simon-mo simon-mo deleted the mp_gradio_serve branch April 27, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants