Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] Improve missing search dependency info #23691

Merged
merged 6 commits into from
Apr 7, 2022
Merged

[tune] Improve missing search dependency info #23691

merged 6 commits into from
Apr 7, 2022

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Apr 4, 2022

Why are these changes needed?

Replaces FLAML searchers with a dummy class that throws an informative error on init if FLAML is not installed, removes ConfigSpace import in BOHB example code, adds a note to examples using external dependencies.

Related issue number

Closes #23551

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

krfricke
krfricke approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, quick question for hints

python/ray/tune/examples/ax_example.py Outdated Show resolved Hide resolved
xwjiang2010
xwjiang2010 approved these changes Apr 4, 2022
View reviewed changes
python/ray/tune/examples/bohb_example.py Outdated Show resolved Hide resolved
@krfricke
Copy link
Contributor

krfricke commented Apr 4, 2022

@Yard1 the soft import test is failing

@krfricke krfricke added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Apr 4, 2022
@Yard1 Yard1 removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Apr 4, 2022
@krfricke krfricke merged commit 434d457 into ray-project:master Apr 7, 2022
edoakes pushed a commit to edoakes/ray that referenced this pull request Apr 7, 2022
@Yard1 @edoakes
[tune] Improve missing search dependency info (ray-project#23691)
701949b 
Replaces FLAML searchers with a dummy class that throws an informative error on init if FLAML is not installed, removes ConfigSpace import in BOHB example code, adds a note to examples using external dependencies.
@Yard1 Yard1 deleted the improve_tune_missing_dep_errors branch April 7, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke krfricke approved these changes

@xwjiang2010 xwjiang2010 xwjiang2010 approved these changes

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

Assignees

@maxpumperla maxpumperla

@krfricke krfricke

@xwjiang2010 xwjiang2010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [Tune] Some scheduler integration examples fail without useful errors when dependencies not installed
4 participants
@Yard1 @krfricke @xwjiang2010 @maxpumperla