Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR] Set name of Trainable to match with Trainer #23697

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Apr 4, 2022

Before

Result logdir: /Users/amog/ray_results/train_func_2022-04-04_13-15-28
Number of trials: 1/1 (1 TERMINATED)
+------------------------+------------+-----------------+--------+------------------+----------+--------------+---------------------+
| Trial name             | status     | loc             |   iter |   total time (s) |     loss |   _timestamp |   _time_this_iter_s |
|------------------------+------------+-----------------+--------+------------------+----------+--------------+---------------------|
| train_func_f84c8_00000 | TERMINATED | 127.0.0.1:15503 |      3 |          3.17087 | 0.300253 |   1649103335 |            0.099402 |
+------------------------+------------+-----------------+--------+------------------+----------+--------------+---------------------+

After

Result logdir: /Users/amog/ray_results/TorchTrainer_2022-04-04_13-19-32
Number of trials: 1/1 (1 TERMINATED)
+--------------------------+------------+-----------------+--------+------------------+----------+--------------+---------------------+
| Trial name               | status     | loc             |   iter |   total time (s) |     loss |   _timestamp |   _time_this_iter_s |
|--------------------------+------------+-----------------+--------+------------------+----------+--------------+---------------------|
| TorchTrainer_8a298_00000 | TERMINATED | 127.0.0.1:15624 |      3 |           3.3461 | 0.278467 |   1649103579 |            0.135264 |
+--------------------------+------------+-----------------+--------+------------------+----------+--------------+---------------------+

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@amogkam amogkam merged commit 4530349 into ray-project:master Apr 4, 2022
@amogkam amogkam deleted the air-trainable-name branch April 4, 2022 23:23
edoakes pushed a commit to edoakes/ray that referenced this pull request Apr 7, 2022
@richardliaw richardliaw added this to the Ray AIR milestone Apr 8, 2022
@amogkam amogkam mentioned this pull request Apr 20, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants