[RLlib] Issue 23689: tf Initializer has hard-coded float32 dtype. #23741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
avnishn
approved these changes
Apr 6, 2022
|
The idea is fine but I guess we'll need some function to convert to the analogous np type. |
|
a lot of unit test failure though. I think the default type for dtype may need to be np.float32. |
|
Oh, yeah, didn't even think about this. Let's just make float32 the default (instead of None). I do think float64 could also make sense here, so the PR and issue themselves are valid. |
…e_23689_hardcoded_initializer_dtype
…e_23689_hardcoded_initializer_dtype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[RLlib] Issue 23689: tf Initializer has hard-coded float32 dtype.
Why are these changes needed?
Issue #23689
Related issue number
Closes #23689
Checks
scripts/format.shto lint the changes in this PR.