Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] MARWIL: Move to training_iteration API. #23798

Merged
merged 26 commits into from
Apr 11, 2022
Merged

[RLlib] MARWIL: Move to training_iteration API. #23798

merged 26 commits into from
Apr 11, 2022

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Apr 8, 2022 •
edited

MARWIL: Move to training_iteration API.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

ArturNiederfahrenhorst
ArturNiederfahrenhorst approved these changes Apr 10, 2022
View reviewed changes
Copy link
Contributor

@ArturNiederfahrenhorst ArturNiederfahrenhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a generic training iteration fn for imitation learning?

@sven1977 sven1977 merged commit a3d4fc7 into ray-project:master Apr 11, 2022
avnishn
avnishn reviewed Apr 11, 2022
View reviewed changes
Copy link
Contributor

@avnishn avnishn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a retroactive review with some questions. Nice change :)

rllib/agents/ppo/ddppo.py Show resolved Hide resolved
rllib/agents/marwil/marwil.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avnishn avnishn avnishn left review comments

@ArturNiederfahrenhorst ArturNiederfahrenhorst ArturNiederfahrenhorst approved these changes

@gjoliver gjoliver Awaiting requested review from gjoliver

@smorad smorad Awaiting requested review from smorad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sven1977 @ArturNiederfahrenhorst @avnishn