[Tune] Don't include nan metrics for best checkpoint #23820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuehaiPan
reviewed
Apr 10, 2022
Comment on lines
+455
to
+459
| # Filter out nan. Sorting nan values leads to undefined behavior. | ||
| checkpoint_paths = [ | ||
| (path, metric) for path, metric in checkpoint_paths if not is_nan(metric) | ||
| ] | ||
|
|
There was a problem hiding this comment.
I think we should also check whether the filtered list is empty.
In addition, we can also have a fallback option when all metric values are nan. For example, if all are nan, return the latest checkpoint.
There was a problem hiding this comment.
I think we could just move the filtering above the if not checkpoint_paths check.
|
Can we add a sentence to the docstring that nan checkpoints will be filtered out? Thanks! |
Yard1
approved these changes
Apr 11, 2022
|
Failing tests are unrelated, going to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nan values do not have a well defined ordering. When sorting metrics to determine the best checkpoint, we should always filter out checkpoints that are associated with nan values.
Closes #23812
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.